jQuery Plug-In Feedback
- Last post
- 10 Responses
Hi y'all - I wrote a new jQuery plug-in called jQuery Image Scale Carousel.
Any feedback or thoughts would be greatly appreciated. Just a warning: I haven't tested it in IE at all yet. I'm expecting the worst.
works and feels great in safari. bravo!
Looks good - just a small thing - I'd stuff your jumpTo and posCount functions into the anonymous closure so that they protected from getting overwritten. Otherwise 3rd party code could overwrite and mess things up quite a bit. In fact, I'd move all of the defined vars inside as well so they are all protected. Especially since you are using variable names like "x" and "y" which are very common.
- Awesome advice. On the todo list. Thanks.foobaz
I'm no JS expert so I'll leave that to others, but in terms of functionality it's simply awesome. Nice job!!
Like it, would like it better if there was an auto scroll option and a cycle-through option.
- Auto scroll is easy enough to implement. I will add it. Thanks!foobaz
Just wanted to say thanks for the great feedback. I worked on it over the weekend and have implemented auto-play and secured the global variables to avoid collisions.
Nice work. I could see this being very useful.
Looks pretty sweet to me! Bookmarked it because I think I'll likely have a use for it in the future.
Also - nice work on the other flickr plugin. I've been working on something very similar to that as a personal project for some time now, but my "real work" seems to always get in the way.
I like the way that you store images in array so you don't have to add and hide them in html;
The options I would put to the line where you call your stuff and use JSON format, something like below:
- Thanks. Great advice. Script altered and does just that now. Cheers!foobaz